Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ASM module: "revision_name" variable not passed through #1022

Closed
jtangney opened this issue Oct 8, 2021 · 0 comments · Fixed by #1048
Closed

ASM module: "revision_name" variable not passed through #1022

jtangney opened this issue Oct 8, 2021 · 0 comments · Fixed by #1048

Comments

@jtangney
Copy link
Contributor

jtangney commented Oct 8, 2021

module "asm" {
  source                = "terraform-google-modules/kubernetes-engine/google//modules/asm"
  asm_version           = "1.10"
  revision_name         = "asm-110"
....
}

With the above configuration, istiod should be labelled with "istio.io/rev: asm-110". However, it is not working - istiod is labelled with the default full version string e.g. "istio.io/rev: asm-1104-14".

The revision_name parameter is correctly passed to scripts/install_asm.sh.
However, that script then does not pass it through to the downloaded ./install_asm_${ASM_VERSION} script.
The ${REVISION_NAME_COMMAND_SNIPPET} variable is never initialised.

I will open a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant