feat: Add support for gpu_partition_size
#1072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It would be fine to change the existing machine/location to one which allows GPU partitioning (just need to adjust tests as well). |
|
Thanks for the PR! 🚀 |
stanley98yu
requested review from
bharathkkb,
Jberlinsky and
a team
as code owners
morgante
approved these changes
Nov 23, 2021
bharathkkb
pushed a commit
that referenced
this pull request
Jan 21, 2022
* Add support for gpu_partition_size * Add test for gpu_partition_size * Lint formatting fix
CPL-markus
pushed a commit
to WALTER-GROUP/terraform-google-kubernetes-engine
that referenced
this pull request
Jul 15, 2024
…1072) * Add support for gpu_partition_size * Add test for gpu_partition_size * Lint formatting fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #1045. The
gpu_partition_sizefield behaves unexpectedly and is required, not optional, in provider versions 3.90+, so we default tonullas a workaround.I was also thinking about adding a test, but I'm not sure how to approach it. The accelerator types supported by the machine and location in the example
node_pooldo not allow GPU partitioning (I specifically triednvidia-tesla-k80andnvidia-tesla-a100). Would this require a new example?