Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Identity Service in beta-private-cluster-update-variant #1137

Closed
vasrem opened this issue Jan 31, 2022 · 0 comments · Fixed by #1142
Closed

Add support for Identity Service in beta-private-cluster-update-variant #1137

vasrem opened this issue Jan 31, 2022 · 0 comments · Fixed by #1142
Labels
enhancement New feature or request P2 high priority issues triaged Scoped and ready for work

Comments

@vasrem
Copy link

vasrem commented Jan 31, 2022

TL;DR

Incorporate the feature introduced by this PR hashicorp/terraform-provider-google-beta#3957 into the beta-private-cluster-update-variant in order to be able to enable Identity Service using a flag similarly to enable_pod_security_policy flag.

Terraform Resources

* https://registry.terraform.io/providers/hashicorp/google/latest/docs/resources/container_cluster
* https://registry.terraform.io/providers/hashicorp/google/latest/docs/resources/container_cluster#nested_identity_service_config
* https://github.com/hashicorp/terraform-provider-google-beta/releases/tag/v4.6.0

Detailed design

I believe that this should be implemented similarly to https://github.com/terraform-google-modules/terraform-google-kubernetes-engine/blob/e6b928288cdd79035d32ea84fd8ce6ca40979246/modules/beta-private-cluster-update-variant/cluster.tf#L123-L128. This is a known pattern as far as I can tell from the code so I believe there should not be much to be added in the design. Let me know if there are questions and I'll try to answer them.

Additional information

No response

@vasrem vasrem added the enhancement New feature or request label Jan 31, 2022
@morgante morgante added P2 high priority issues triaged Scoped and ready for work labels Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request P2 high priority issues triaged Scoped and ready for work
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants