Apply applicable ASM_OPTS in config_map #1183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Monkeyanator PTAL |
|
Thanks for the PR! 🚀 |
Monkeyanator
approved these changes
Mar 17, 2022
| @@ -45,6 +45,7 @@ resource "kubernetes_config_map" "asm_options" { | |||
|
|
|||
| data = { | |||
| multicluster_mode = var.multicluster_mode | |||
| ASM_OPTS = var.enable_cni ? "CNI=on" : null | |||
There was a problem hiding this comment.
nit: should this be
Suggested change
| ASM_OPTS = var.enable_cni ? "CNI=on" : null | |
| ASM_OPTS = var.enable_cni ? "CNI=on" : "" |
?
There was a problem hiding this comment.
Do we want it to be set to "" or excluded entirely? Usually I think excluding is better.
There was a problem hiding this comment.
When set to null the value is not applied to the configMap. Empty value could trigger unintended behavior.
There was a problem hiding this comment.
Agreed, let's stick to null.
morgante
approved these changes
Mar 21, 2022
CPL-markus
pushed a commit
to WALTER-GROUP/terraform-google-kubernetes-engine
that referenced
this pull request
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[In autopilot clusters,] subsequent terraform runs overwrite the
ASM_OPTS: "CNI=on"value in the asm_option config map. This prevents new or restating workloads from being scheduled as the proxy tries to cap add NET_ADMIN on start. This PR conditionally adds the expected setting.