-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flaky CI failures due to kube-dns CM conflict #1197
Comments
We may have to switch to modifying the CM inplace. b/192419589 for context |
FYI: |
@apeabody Wouldn't the existing tests pass with a label added by |
Yes, but as it would be a separate operation from the configMap application it wouldn't be linked to if the configMap was successful or unsuccessful. However if we think there is still value in applying and checking the label in its own right, I can certainly include it. Let me know what you prefer @bharathkkb. |
Ah I see what you meant. I think there is still value in having the label as it signifies that the resource is managed by Terraform. For the test, asserting expected contents might be better (although lets defer changing this along with updating the test framework) |
Looking at using the ManagedField property instead of Label as it appears kubernetes_labels and kubernetes_config_map_v1_data conflict hashicorp/terraform-provider-kubernetes#1690 |
TL;DR
For functionality like stubdomains, we delete and recreate the
kube-dns
config map. Recently we have been observing flaky errors in CI where Terraform (via kubectl-wrapper) deleteskube-dns
config map but subsequent creation viakubernetes_config_map
fails due to conflict.The cause seems to be that addon-manager is recreating that config map after delete which leads to the conflict. The CM has the label
addonmanager.kubernetes.io/mode: EnsureExists
. Some relevant logs filtered fornamespaces/kube-system/configmaps/kube-dns
Expected behavior
No response
Observed behavior
No response
Terraform Configuration
Terraform Version
Additional information
No response
The text was updated successfully, but these errors were encountered: