Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

min_cpu_platform doesn't work on node pools #1216

Closed
dantheperson opened this issue Apr 12, 2022 · 2 comments · Fixed by #1207
Closed

min_cpu_platform doesn't work on node pools #1216

dantheperson opened this issue Apr 12, 2022 · 2 comments · Fixed by #1207

Comments

@dantheperson
Copy link

dantheperson commented Apr 12, 2022

Actual
All node pools take the min_cpu_platform of the first node pool
Expected
Node pools takes the min_cpu_platform defined in their node pool declaration.

https://github.com/terraform-google-modules/terraform-google-kubernetes-engine/blob/master/modules/private-cluster/cluster.tf#L284

- min_cpu_platform = lookup(var.node_pools[0], "min_cpu_platform", "")
+min_cpu_platform = lookup(each.value, "min_cpu_platform", "")

Looks like the bug is across all the different cluster modules

For example with this configuration, both node pools have min_cpu_platform="AMD Rome"

  node_pools = [
    {
      name               = "platform"
      machine_type       = "n2d-standard-4"
      min_cpu_platform   = "AMD Rome

    },
    {
      name               = "elasticsearch"
      machine_type       = "n2d-standard-4"
      min_cpu_platform   = "AMD Milan"

    },
@lauraseidler
Copy link
Contributor

I think the fix for this is in #1207

@dantheperson
Copy link
Author

Indeed, #1207 looks like it'll fix it to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants