Asm kubectl internal endpoint #1219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f4tal-err0r
requested review from
a team,
Jberlinsky and
bharathkkb
as code owners
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). For more information, open the CLA check for this pull request. |
f4tal-err0r
force-pushed
the
asm-kubectl-internal-endpoint
branch
from
9e9bcff
to
538c2fd
Compare
|
Thanks for the PR! 🚀 |
bharathkkb
approved these changes
Apr 13, 2022
CPL-markus
pushed a commit
to WALTER-GROUP/terraform-google-kubernetes-engine
that referenced
this pull request
Jul 15, 2024
…ogle-modules#1219) * add variable to use internal ip endpoints when running kubectl commands * update README.md * generate modules, docs and trailing whitespace * rename to just internal_ip Co-authored-by: Yared Mekuria <yared.mekuria@bettercloud.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running terraform deployments of ASM from inside a GCP VPC there is currently no way to specify an internal endpoint for the underlying kubectl commands to execute. This variable will expose that option.