Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support max_surge in non-beta GKE cluster variants #1258

Closed
catherinetcai opened this issue May 18, 2022 · 2 comments · Fixed by #1318
Closed

Support max_surge in non-beta GKE cluster variants #1258

catherinetcai opened this issue May 18, 2022 · 2 comments · Fixed by #1318
Labels
enhancement New feature or request good first issue Good for newcomers Stale

Comments

@catherinetcai
Copy link

catherinetcai commented May 18, 2022

TL;DR

Surge upgrades for GKE are supported in the beta cluster variants. Would it be possible to add support for the max_surge upgrades in the non-beta cluster variants as well?

Terraform Resources

We just need to expose the upgrade_settings section to the private cluster variants.

Detailed design

We just need to take this section and add it here.

Additional information

No response

@catherinetcai catherinetcai added the enhancement New feature or request label May 18, 2022
@bharathkkb
Copy link
Member

Hi @catherinetcai
Happy to review a PR adding this. We can remove the beta feature gate here.

@github-actions
Copy link

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers Stale
Projects
None yet
2 participants