-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
the variable "kubernetes_version" is not usable on module beta-private-cluster and safer-cluster #1279
Comments
Also suffering from this issue in v21.1.0. Set CP to v1.21.x, I can see in the plan the version I want but version 1.22.x (default gcloud version) gets deployed. |
As above, ver 21.1.0, make this module unusable for my purposes. |
I ran into this problem as well, except I was using: module "cluster" {
source = "terraform-google-modules/kubernetes-engine/google//modules/beta-private-cluster-update-variant"
version = "20.0.0"
kubernetes_version = "latest"
release_channel = "REGULAR" The problem seems to be that setting terraform-google-kubernetes-engine/modules/beta-private-cluster-update-variant/cluster.tf Line 62 in 774fc12
In my case, the resulting cluster version was the default version for new clusters (1.22.8) instead of the latest available (1.23.5) as I expected: |
In v21.2.0 instead of using |
By replacing the value Could there be any particular reason for this logic? |
Thanks for the report @maximeancellin and others. I merged a fix which should recognize |
@bharathkkb Awesome, thank you! Since the UI allows us to select a channel (e.g. REGULAR) with a specific version (1.23), is it possible to do the same in the module? Or to set a minimum version constraint? Otherwise, the only option will be to always use the oldest supported version of a given channel (or manually upgrade) |
@bharathkkb will there be a fix where you can select an actual release channel and the version from that channel like in the UI? |
I've created this feature to track my request as it is separate from the original issue: #1356 |
TL;DR
Hi,
When you try to define a value in variable
kubernetes_version
on module safer-cluster. the value isn't used onplan
.Case tested with all type of release channel (
UNSPECIFIED
included).Expected behavior
I would force to use an available version of GKE and decide when I want to upgrade the master of GKE.
I gave a specific version to do it and set the release channel to
UNSPECIFIED
.Observed behavior
When I plan my configuration Terraform take the version latest of the current release channel.
Terraform Configuration
Configuration:
Version: 4.22.0
Version: 4.22.0
Additional information
We cannot choose the Kubernetes version we want to deploy or when we want to perform upgrade (or manually on the console but it's not a goal to do this if we use Terraform)
The issue seems similar like this one: #675
Thanks by advance for your support.
The text was updated successfully, but these errors were encountered: