feat: Add maintenance variables for safer cluster module #1282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christiangonre
requested review from
a team,
Jberlinsky and
bharathkkb
as code owners
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
christiangonre
force-pushed
the
safer-cluster-maintenance-options
branch
from
0f7d1e7
to
aca1647
Compare
|
Thanks for the PR! 🚀 |
christiangonre
force-pushed
the
safer-cluster-maintenance-options
branch
from
aca1647
to
f25028b
Compare
christiangonre
force-pushed
the
safer-cluster-maintenance-options
branch
from
24f42e5
to
ffc7866
Compare
bharathkkb
changed the title
bharathkkb
approved these changes
Jun 21, 2022
bmenasha
pushed a commit
to bmenasha/terraform-google-kubernetes-engine
that referenced
this pull request
Feb 17, 2023
…odules#1282) Co-authored-by: Bharath KKB <bharathkrishnakb@gmail.com>
CPL-markus
pushed a commit
to WALTER-GROUP/terraform-google-kubernetes-engine
that referenced
this pull request
Jul 15, 2024
…odules#1282) Co-authored-by: Bharath KKB <bharathkrishnakb@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request enables the variables maintenance_exclusions, maintenance_end_time and maintenance_recurrence on the safer cluster module.
These variables were already implemented on the beta private cluster module.
Closes #1281