Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add exclusion_options option for maintenance_exclusion setting #1297

Closed
vasrem opened this issue Jun 20, 2022 · 3 comments
Closed

Add exclusion_options option for maintenance_exclusion setting #1297

vasrem opened this issue Jun 20, 2022 · 3 comments
Labels
breaking enhancement New feature or request P3 medium priority issues triaged Scoped and ready for work

Comments

@vasrem
Copy link

vasrem commented Jun 20, 2022

TL;DR

Currently there is no support for https://registry.terraform.io/providers/hashicorp/google/latest/docs/resources/container_cluster#exclusion_options whenever someone uses maintenance_exclusion. This is not flexible enough since it defaults to NO_MINOR_UPGRADES according to https://cloud.google.com/kubernetes-engine/docs/concepts/maintenance-windows-and-exclusions#scope_of_maintenance_to_exclude.

Terraform Resources

https://registry.terraform.io/providers/hashicorp/google/latest/docs/resources/container_cluster#exclusion_options

Detailed design

This is a change in https://github.com/terraform-google-modules/terraform-google-kubernetes-engine/blob/37b5da85b06d289abf6eeafcbb2df3cfec998bec/autogen/main/cluster.tf.tmpl#L262-L269. 

This change probably introduces breaking API change since the variable type needs to be expanded https://github.com/terraform-google-modules/terraform-google-kubernetes-engine/blob/37b5da85b06d289abf6eeafcbb2df3cfec998bec/autogen/main/variables.tf.tmpl#L111-L115.

This change requires google provider version >= 4.22.0
https://github.com/hashicorp/terraform-provider-google/blob/main/CHANGELOG.md#4220-may-24-2022

Additional information

No response

@vasrem vasrem added the enhancement New feature or request label Jun 20, 2022
@bharathkkb
Copy link
Member

Happy to review a PR adding this

@bharathkkb bharathkkb added triaged Scoped and ready for work P3 medium priority issues breaking labels Jun 21, 2022
@bharathkkb
Copy link
Member

fixed by #1273

@vasrem
Copy link
Author

vasrem commented Jun 25, 2022

I'm sorry for the duplicate issue, I didn't notice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking enhancement New feature or request P3 medium priority issues triaged Scoped and ready for work
Projects
None yet
Development

No branches or pull requests

2 participants