Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add gke_backup_agent_config arg #1316

Merged
merged 2 commits into from
Jul 19, 2022

Conversation

DrFaust92
Copy link
Contributor

Closes #1257

@DrFaust92 DrFaust92 requested review from a team, Jberlinsky and bharathkkb as code owners July 10, 2022 19:36
@DrFaust92 DrFaust92 changed the title add gke_backup_agent_config arg feat: add gke_backup_agent_config arg Jul 10, 2022
Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @DrFaust92

autogen/main/cluster.tf.tmpl Outdated Show resolved Hide resolved
@comment-bot-dev
Copy link

@DrFaust92
Thanks for the PR! 🚀
✅ Lint checks have passed.

@bharathkkb bharathkkb merged commit cff4428 into terraform-google-modules:master Jul 19, 2022
@wyardley
Copy link
Contributor

wyardley commented Aug 6, 2022

Is it expected that it takes a really long time to apply the change (like 20-30m), even though the backup config is already disabled?

Similar behavior to mine, btw (#1332)

~ resource "google_container_cluster" "primary" {
        id                          = "projects/xxxx"
        name                        = "xx"
        # (28 unchanged attributes hidden)

      ~ addons_config {

          + gke_backup_agent_config {
              + enabled = false
            }

            # (9 unchanged blocks hidden)
        }

        # (20 unchanged blocks hidden)
    }

CPL-markus pushed a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this pull request Jul 15, 2024
* add gke_backup_agent_config arg

* CR comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Backup for GKE feature setting
4 participants