Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACM submodule missing variable #1369

Closed
szihai opened this issue Aug 24, 2022 · 3 comments · Fixed by #1373
Closed

ACM submodule missing variable #1369

szihai opened this issue Aug 24, 2022 · 3 comments · Fixed by #1373
Assignees
Labels
bug Something isn't working enhancement New feature or request triaged Scoped and ready for work

Comments

@szihai
Copy link

szihai commented Aug 24, 2022

TL;DR

The variable referential_rules_enabled is not listed in the acm submodule : https://github.com/terraform-google-modules/terraform-google-kubernetes-engine/blob/master/modules/acm/feature.tf#L56

Expected behavior

referential_rules_enabled is required to have 2 additional constrainttemplates installed. In the acm example, it is used: https://github.com/terraform-google-modules/terraform-google-kubernetes-engine/blob/master/modules/acm/feature.tf#L56
However in the sub-module it is missing.

Observed behavior

Without this variable set to true, the constrainttemplates asmpeerauthnmeshstrictmtls and asmauthzpolicydefaultdeny are missing.

Terraform Configuration

policy_controller {
      enabled                    = true
      template_library_installed = true
      referential_rules_enabled  = true
 }

Terraform Version

Terraform v1.2.7

Additional information

No response

@szihai szihai added the bug Something isn't working label Aug 24, 2022
@apeabody apeabody added the enhancement New feature or request label Aug 24, 2022
@apeabody apeabody self-assigned this Aug 24, 2022
@apeabody apeabody added the triaged Scoped and ready for work label Aug 24, 2022
@apeabody
Copy link
Contributor

Hi @szihai - Thanks for reaching out about Policy Controller! You can track the outcome at #1373

@szihai
Copy link
Author

szihai commented Aug 25, 2022

Glad to see the MR. Thank you for the quick response!

@apeabody
Copy link
Contributor

Hi @szihai - You can watch #1374 for the release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request triaged Scoped and ready for work
Projects
None yet
2 participants