Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add Backup for GKE option for private-cluster module #1450

Closed
tomekzielins opened this issue Nov 3, 2022 · 2 comments · Fixed by #1513
Closed

add Backup for GKE option for private-cluster module #1450

tomekzielins opened this issue Nov 3, 2022 · 2 comments · Fixed by #1513
Labels
enhancement New feature or request good first issue Good for newcomers triaged Scoped and ready for work

Comments

@tomekzielins
Copy link

TL;DR

Since Backup for GKE service has moved from BETA to GA please add option to use variable gke_backup_agent_config in private_cluster variant. Similarly as it is done beta-private-cluster variant.

Terraform Resources

https://registry.terraform.io/providers/hashicorp/google/latest/docs/resources/container_cluster#gke_backup_agent_config

Detailed design

No response

Additional information

No response
@tomekzielins tomekzielins added the enhancement New feature or request label Nov 3, 2022
@bharathkkb
Copy link
Member

Thanks for the report @tomekzielins. Happy to review a PR updating this

@bharathkkb bharathkkb added good first issue Good for newcomers triaged Scoped and ready for work labels Nov 16, 2022
This was referenced Nov 29, 2022
Closed
Merged
@shubhamkr619
Copy link
Contributor

@bharathkkb Please assign this to me

@kkram01 kkram01 mentioned this issue Dec 1, 2022
Merged
5 tasks
This was referenced Dec 12, 2022
Merged
Merged
@Tolsee Tolsee mentioned this issue Dec 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers triaged Scoped and ready for work
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat!: promote gke_backup_agent_config to ga Tolsee/terraform-google-kubernetes-engine
3 participants
@shubhamkr619 @bharathkkb @tomekzielins