Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a service activation module #146

Merged
merged 3 commits into from
Jan 23, 2020
Merged

Add a service activation module #146

merged 3 commits into from
Jan 23, 2020

Conversation

morgante
Copy link
Contributor

This is a simple submodule which can be used to activate all required services.

@aaron-lane
Copy link
Contributor

@morgante is this ready for review?

@morgante
Copy link
Contributor Author

@aaron-lane Not yet.

@aaron-lane aaron-lane added the enhancement New feature or request label Jun 3, 2019
@Jberlinsky
Copy link
Contributor

@morgante Could you kindly mark this PR as Draft?

@morgante
Copy link
Contributor Author

morgante commented Jul 8, 2019

@Jberlinsky The "WIP" in the title should be sufficient? There's no way to mark PRs as drafts AFAIK.

@Jberlinsky
Copy link
Contributor

Ah, yes, my mistake -- a PR can only be marked as Draft when creating it. Carry on :)

@morgante morgante changed the title [WIP] Start a service activation module Add a service activation module Dec 9, 2019
@morgante morgante merged commit 658ea51 into master Jan 23, 2020
kri5 pushed a commit to kri5/terraform-google-kubernetes-engine that referenced this pull request Jan 27, 2020
* Start a service activation module

* Complete proejct services submodule

* Pass through variables
CPL-markus pushed a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this pull request Jul 15, 2024
* Start a service activation module

* Complete proejct services submodule

* Pass through variables
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants