Module doesnt honor specified GKE master version

[kkapoor1987]

TL;DR

When both the release channel and master version are specified the module ignores the master version which creates a discrepancy in the intended cluster version vs what the module is creating.

https://github.com/terraform-google-modules/terraform-google-kubernetes-engine/blob/master/modules/private-cluster/cluster.tf#L57

Expected behavior

If you user specifies the version module should either use that version or fail provisioning with error message version not supported

Observed behavior

We use this module to deploy GKE clusters. We use a Stable release channel but control the master version so that we can reliably deploy the same K8s version across our fleet.

Terraform Configuration

module "gke" {
  source             = "terraform-google-modules/kubernetes-engine/google//modules/private-cluster"
  version            = "23.3.0"
  project_id         = var.AccountID
  name               = var.ClusterName
  kubernetes_version = local.latest_gke_patched_version
  regional           = true
  region             = var.Region
  network            = var.ClusterName
  subnetwork         = var.ServiceSubnets[0]
  ip_range_pods      = var.PodRange
  ip_range_services  = var.ClusterServiceRangeName
  horizontal_pod_autoscaling = true
  database_encryption        = local.cluster_encryption_config
  enable_private_endpoint  = false
  enable_private_nodes     = true
  remove_default_node_pool = true
  network_policy           = true
  monitoring_service       = "none"
  master_ipv4_cidr_block   = "10.0.64.0/28"
  logging_service = "logging.googleapis.com/kubernetes"
  cluster_resource_labels           = local.tags
  node_pools                 = local.node_pools
  master_authorized_networks = local.master_authorized_networks
  
  # Release Channel configuration
  release_channel = var.release_channel_version
  maintenance_exclusions = [{
    name = "minor_upgrade_exclusion"
    start_time = timestamp()
    end_time = timeadd(timestamp(),local.end_time_in_hrs)
    exclusion_scope = "NO_MINOR_UPGRADES" # Scope should be one of: NO_UPGRADES | NO_MINOR_UPGRADES | NO_MINOR_OR_NODE_UPGRADES
  }]
}

Terraform Version

1.0.11

Additional information

No response

[github-actions]

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

[slimatic]

Can this be reopened?

[slimatic]

A new pull request PR #1625 has been opened related to the issue.