Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gateway Controller is GA #1462

Closed
nlamirault opened this issue Nov 15, 2022 · 5 comments · Fixed by #1510
Closed

Gateway Controller is GA #1462

nlamirault opened this issue Nov 15, 2022 · 5 comments · Fixed by #1510
Labels
enhancement New feature or request triaged Scoped and ready for work upstream Work required on Terraform core or provider

Comments

@nlamirault
Copy link

TL;DR

Since Gateway Controller is GA, it would be interesting to have it in the configuration options.

https://cloud.google.com/blog/products/containers-kubernetes/google-kubernetes-engine-gateway-controller-is-now-ga?hl=en

Terraform Resources

No response

Detailed design

No response

Additional information

No response
@nlamirault nlamirault added the enhancement New feature or request label Nov 15, 2022
@bharathkkb
Copy link
Member

Thanks for the report @nlamirault
Looks like this is being added to the provider in GoogleCloudPlatform/magic-modules#6875. Happy to review a PR once this is added to the provider.

@bharathkkb bharathkkb added triaged Scoped and ready for work upstream Work required on Terraform core or provider labels Dec 9, 2022
@tuunit
Copy link
Contributor

tuunit commented Dec 12, 2022

@bharathkkb @nlamirault as I'm adding it to the provider anyway I can create a pull request for this repository as well. I'll be back in touch in a few days.

@tuunit
Copy link
Contributor

tuunit commented Dec 15, 2022

@nlamirault my terraform provider change to enable the gateway controller workflow GoogleCloudPlatform/magic-modules#6875 was merged. I can already start implementing it for this module with my local build but we will have to wait for the next official terraform provider release.

@tuunit
Copy link
Contributor

tuunit commented Dec 23, 2022

@nlamirault @lauraseidler Gateway API is now part of the latest terraform google provider: https://github.com/hashicorp/terraform-provider-google/releases/tag/v4.47.0

I'll have a look at integrating it into this module now. All the best and happy christmas 🎄

@tuunit tuunit mentioned this issue Dec 26, 2022
Merged
@tuunit
Copy link
Contributor

tuunit commented Dec 26, 2022

@nlamirault @lauraseidler PR is open #1510

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request triaged Scoped and ready for work upstream Work required on Terraform core or provider
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat!: support for gateway api tuunit/terraform-google-kubernetes-engine
3 participants
@nlamirault @bharathkkb @tuunit