Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Binary authorization parameter seams to be skipped #1468

Closed
DS-KrzJon opened this issue Nov 18, 2022 · 2 comments
Closed

Binary authorization parameter seams to be skipped #1468

DS-KrzJon opened this issue Nov 18, 2022 · 2 comments
Labels
question Further information is requested Stale

Comments

@DS-KrzJon
Copy link

DS-KrzJon commented Nov 18, 2022

Module: terraform-google-modules/kubernetes-engine/google//modules/beta-private-cluster-update-variant
Version: 22.0.0 in comparission to 23.3.0

We are using enable_binary_authorization = true as fixed value, but the cluster created in the past (TF CLI 1.2.1 and Module 22.0.0) is now disabling the enable_binary_authorization (TF CLI 1.3.2 and Module 23.3.0).

GKE Version (Stable 1.23.11-gke.300)
image

Is there a quick workaround? Is it really broken?
In the past I saw only the information that enable_binary_authorization will be deprecated in favour of binary_authorization. Maybe someone who knows more could check what's goin on. It's very annoing issue.

@bharathkkb
Copy link
Member

I believe that is expected, do you see a diff of the new block getting created too?

      + binary_authorization {
          + evaluation_mode = "PROJECT_SINGLETON_POLICY_ENFORCE"
        }

as explained by the author here
#1332 (comment)

@bharathkkb bharathkkb added the question Further information is requested label Nov 19, 2022
@github-actions
Copy link

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the Stale label Jan 18, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested Stale
Projects
None yet
Development

No branches or pull requests

2 participants