Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting network tags in the beta-autopilot-private-cluster submodule #1496

Closed
gmspinheiro opened this issue Dec 13, 2022 · 5 comments
Closed
Assignees
Labels
enhancement New feature or request

Comments

@gmspinheiro
Copy link

TL;DR

The submodule that handles the creation of private autopilot clusters should also allow setting network tags.

Terraform Resources

https://registry.terraform.io/providers/hashicorp/google/latest/docs/resources/container_cluster#network_tags

Detailed design

resource "google_container_cluster" "primary" {
  provider = google-beta

  name            = var.name

  # ...

  dynamic "node_pool_auto_config" {
    for_each = length(var.network_tags) > 0 ? [1] : []
    content {
      network_tags {
        tags = var.network_tags
      }
    }
  }
}

variable "network_tags" {
  description = "(Optional, Beta) - List of network tags applied to auto-provisioned node pools."
  type = list(string)
  default = []
}

Additional information

No response

@gmspinheiro gmspinheiro added the enhancement New feature or request label Dec 13, 2022
@guicane
Copy link

guicane commented Dec 21, 2022

Yes please, I thought I was going crazy, I guess I'm not alone.

@rpmduarte
Copy link

please make this available

@github-actions
Copy link

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the Stale label Feb 19, 2023
@ferrarimarco
Copy link
Contributor

Not stale.

@gtsorbo
Copy link
Collaborator

gtsorbo commented Mar 1, 2023

Resolved in #1572

@gtsorbo gtsorbo closed this as completed Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants