feat!: support for gateway api for safer cluster variants

[lauraseidler]

Follow up to #1510

[ericyz]

Re-run the checks

[lauraseidler]

Re-run the checks

Can't, unfortunately, I don't think I have the necessary permissions

[ericyz]

Re-run the checks

Can't, unfortunately, I don't think I have the necessary permissions

I have re-triggered it for you.

[lauraseidler]

Still no luck it seems :(

[apeabody]

Thanks for the contribution @lauraseidler! - I suspect the test failure is related to #1525

[lauraseidler]

Could be - it's really hard to figure out without having access to the builds. I guess I'll wait for the fix, then rebase and see if it works then.

[tuunit]

@lauraseidler sorry that I missed to add this feature to the safer cluster module as well in the initial PR

[lauraseidler]

@apeabody Thanks for the fix!
@tuunit no worries, I think most people do

[ericyz]

Thanks @lauraseidler for the contribution. LGTM overall. Just a minor comment here. Could you please also update the modules/safer-cluster/variables.tf to pin the Google provider version >= 4.47.0

[lauraseidler]

@ericyz the google provider version is currently not in there at all - do you want me to add it? I think since the safer cluster variants just use the beta private cluster module with some variables set to defaults, it's not necessary. However, I see that the versions.tf files in some modules that do specify them haven't been updated - maybe those need to be updated instead https://github.com/terraform-google-modules/terraform-google-kubernetes-engine/blob/master/autogen/main/versions.tf.tmpl#L27?

[lauraseidler]

Yeah I actually think this would break if released as is, as the gateway API support is implemented for the beta clusters, but the provider constraint is not there - I pushed the increase, so probably it's a good idea to merge this before #1512.

[ericyz]

Yeah I actually think this would break if released as is, as the gateway API support is implemented for the beta clusters, but the provider constraint is not there - I pushed the increase, so probably it's a good idea to merge this before #1512.

Thanks @lauraseidler . Yes, it implicitly uses other modules. That's all good

[ericyz]

LGTM and will approve once the CI passed

[comment-bot-dev]

@lauraseidler
Thanks for the PR! 🚀
✅ Lint checks have passed.

[apeabody]

Thanks for the contribution @lauraseidler!