Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for policy bundles and metrics SA #1529

Merged
merged 4 commits into from
Feb 1, 2023
Merged

feat: add support for policy bundles and metrics SA #1529

merged 4 commits into from
Feb 1, 2023

Conversation

apeabody
Copy link
Contributor

No description provided.

@apeabody apeabody force-pushed the ap-poco-1a branch 16 times, most recently from 76ce65e to 406f9b4 Compare January 13, 2023 01:21
@apeabody apeabody force-pushed the ap-poco-1a branch 6 times, most recently from ff06dfe to dbc7f6c Compare January 25, 2023 19:00
@apeabody apeabody marked this pull request as ready for review January 26, 2023 16:54
@apeabody apeabody requested review from a team, Jberlinsky and ericyz as code owners January 26, 2023 16:54
bharathkkb
bharathkkb approved these changes Jan 27, 2023
View reviewed changes
Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @apeabody

examples/simple_zonal_with_acm/acm.tf Outdated Show resolved Hide resolved
modules/acm/policy_bundles.tf Outdated Show resolved Hide resolved
@apeabody apeabody force-pushed the ap-poco-1a branch 3 times, most recently from 39db552 to fa9169c Compare January 30, 2023 23:34
@apeabody apeabody force-pushed the ap-poco-1a branch 2 times, most recently from 937f10f to 9fcc546 Compare January 31, 2023 00:55
@apeabody apeabody changed the title feat: add support for policy bundles feat: add support for policy bundles and metrics SA Jan 31, 2023
@apeabody apeabody force-pushed the ap-poco-1a branch 8 times, most recently from 91c3cfb to 65efef0 Compare January 31, 2023 04:31
bharathkkb
bharathkkb approved these changes Jan 31, 2023
View reviewed changes
modules/acm/creds.tf Outdated Show resolved Hide resolved
modules/acm/outputs.tf Show resolved Hide resolved
@apeabody apeabody force-pushed the ap-poco-1a branch 5 times, most recently from 66bd846 to 1146b42 Compare February 1, 2023 01:21
@comment-bot-dev
Copy link

@apeabody
Thanks for the PR! 🚀
✅ Lint checks have passed.

@apeabody apeabody merged commit 0f63eab into master Feb 1, 2023
@apeabody apeabody deleted the ap-poco-1a branch February 1, 2023 04:22
@release-please release-please bot mentioned this pull request Feb 1, 2023
Merged
@jmymy jmymy mentioned this pull request May 11, 2023
Merged
@michaellzc michaellzc mentioned this pull request Nov 23, 2023
Merged
CPL-markus pushed a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this pull request Jul 15, 2024
@apeabody
feat: add support for policy bundles and metrics SA (terraform-google…
270300f 
…-modules#1529)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bharathkkb bharathkkb bharathkkb approved these changes

@Jberlinsky Jberlinsky Awaiting requested review from Jberlinsky

@ericyz ericyz Awaiting requested review from ericyz ericyz is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@apeabody @comment-bot-dev @bharathkkb