asm labelling docs unclear due to ignored var

[zeemy23]

TL;DR

https://github.com/terraform-google-modules/terraform-google-kubernetes-engine/blob/master/modules/asm/README.md

These docs guide the user to add the mesh_id label in a way that this PR from 2021 discontinued support for.

#1061

I can add a PR that clarifies the readme for future users. We were pulling our hair out trying to figure out why the label was getting ignored.

Expected behavior

following asm docs results in asm functionality

Observed behavior

ignored labels causes much strife if following docs

Terraform Configuration

module "gke" {
...
  cluster_resource_labels = { "mesh_id" : "proj-${data.google_project.project.number}" }
...
}

Terraform Version

all versions.

Additional information

No response

[github-actions]

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

[legal90]

That issue is still actual. Should it be reopened? cc @apeabody , @ferrarimarco

Both ASM tf module documentation, as wells as the official Google docs are saying that mesh_id label has to be added explicitly to the cluster:

• https://github.com/terraform-google-modules/terraform-google-kubernetes-engine/blob/3c9a634ceef3fe8fc073de161f17f0064f424c04/modules/asm/README.md
• https://cloud.google.com/service-mesh/docs/managed/provision-managed-anthos-service-mesh#apply_the_mesh_id_label

But, as @zeemy23 said above, this label is ignored on gke tf modules:

terraform-google-kubernetes-engine/autogen/main/cluster.tf.tmpl

Lines 248 to 250 in eeebd78

	lifecycle {
	ignore_changes = [node_pool, initial_node_count, resource_labels["asmv"], resource_labels["mesh_id"]]
	}

It was added by #1061.

[apeabody]

That issue is still actual. Should it be reopened? cc @apeabody , @ferrarimarco

Both ASM tf module documentation, as wells as the official Google docs are saying that mesh_id label has to be added explicitly to the cluster:

• https://github.com/terraform-google-modules/terraform-google-kubernetes-engine/blob/3c9a634ceef3fe8fc073de161f17f0064f424c04/modules/asm/README.md
• https://cloud.google.com/service-mesh/docs/managed/provision-managed-anthos-service-mesh#apply_the_mesh_id_label

But, as @zeemy23 said above, this label is ignored on gke tf modules:

terraform-google-kubernetes-engine/autogen/main/cluster.tf.tmpl

Lines 248 to 250 in eeebd78

	lifecycle {
	ignore_changes = [node_pool, initial_node_count, resource_labels["asmv"], resource_labels["mesh_id"]]
	}

It was added by #1061.

Removed the stale tag and reopened. cc @ferrarimarco who was working on the ASM sub-module.

[ferrarimarco]

Hi! Feel free to propose a PR. I'll review it :)

Thanks!

[legal90]

@ferrarimarco Thank you! Here is the PR: #1836