-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
asm labelling docs unclear due to ignored var #1671
Comments
This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days |
That issue is still actual. Should it be reopened? cc @apeabody , @ferrarimarco Both ASM tf module documentation, as wells as the official Google docs are saying that
But, as @zeemy23 said above, this label is ignored on gke tf modules: terraform-google-kubernetes-engine/autogen/main/cluster.tf.tmpl Lines 248 to 250 in eeebd78
It was added by #1061. |
Removed the stale tag and reopened. cc @ferrarimarco who was working on the ASM sub-module. |
Hi! Feel free to propose a PR. I'll review it :) Thanks! |
@ferrarimarco Thank you! Here is the PR: #1836 |
TL;DR
https://github.com/terraform-google-modules/terraform-google-kubernetes-engine/blob/master/modules/asm/README.md
These docs guide the user to add the mesh_id label in a way that this PR from 2021 discontinued support for.
#1061
I can add a PR that clarifies the readme for future users. We were pulling our hair out trying to figure out why the label was getting ignored.
Expected behavior
following asm docs results in asm functionality
Observed behavior
ignored labels causes much strife if following docs
Terraform Configuration
Terraform Version
Additional information
No response
The text was updated successfully, but these errors were encountered: