Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configuration of mesh_certificates on google_container_cluster #1691

Closed
somethingnew2-0 opened this issue Jul 12, 2023 · 2 comments
Closed
Labels
enhancement New feature or request Stale

Comments

@somethingnew2-0
Copy link
Contributor

TL;DR

In order to use mTLS service security with Traffic Director "Mesh certificates" must be enabled on the cluster. Add the ability for all cluster modules in this repository to enable this functionality with a variable.

Terraform Resources

The documentation for `google_container_cluster` with the `mesh_certificates` block
https://registry.terraform.io/providers/hashicorp/google/latest/docs/resources/container_cluster#enable_certificates

Instructions for `--enable-mesh-certificates` on GKE cluster in the Traffic Director documentation for setting up mTLS certificates
https://cloud.google.com/traffic-director/docs/security-envoy-setup#create-cluster

Detailed design

This could look like exposing an module variable to configure the underlying `google_container_cluster` terraform resource.


mesh_certificates {
  enable_certificates = var.enable_mesh_certificates
}


### Additional information

_No response_
@github-actions
Copy link

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the Stale label Sep 10, 2023
@somethingnew2-0
Copy link
Contributor Author

There is an open PR for this issue that will be merged soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Stale
Projects
None yet
Development

No branches or pull requests

1 participant