Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for google provider v5 #1759

Closed
dzoeteman opened this issue Oct 4, 2023 · 3 comments
Closed

Add support for google provider v5 #1759

dzoeteman opened this issue Oct 4, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@dzoeteman
Copy link

TL;DR

It would be great if the module could support the new v5 version of the google provider.
Specifically, this version of the provider has added the deletion_protection argument for clusters, which makes it so we can prevent the clusters created by the module from being destroyed.

Terraform Resources

No response

Detailed design

No response

Additional information

v5 release changelog: https://github.com/hashicorp/terraform-provider-google/releases/tag/v5.0.0

@ChrisNoSim
Copy link

ChrisNoSim commented Oct 30, 2023

Hi there,

We are encountering significant challenges due to the hashicorp/google provider version restriction in this module. It currently requires version 4.x, while other modules we use have already migrated to depend on version 5.x. At the moment we are unable to make changes to our clusters due to this dependency (specially using module private-cluster).

We're looking forward to support for Google Provider 5.x in this module. Any updates or timelines on this would be greatly appreciated.

Thank you for your attention to this issue. Great job for that module repo in general, because we love to use it.

@TheKangaroo
Copy link
Contributor

I believe this was fixed in #1761 and released in 29.0.0 a few hours ago.

@dzoeteman
Copy link
Author

Closed based on #1761 , thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants