Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use with dual-stack VPC causes cluster recreation #1863

Closed
kliu47 opened this issue Feb 1, 2024 · 2 comments · Fixed by #1924
Closed

Use with dual-stack VPC causes cluster recreation #1863

kliu47 opened this issue Feb 1, 2024 · 2 comments · Fixed by #1924
Labels
bug Something isn't working

Comments

@kliu47
Copy link
Contributor

kliu47 commented Feb 1, 2024

TL;DR

When using a dualstack VPC, cluster tries to be re-created each run due to mismatch in enable_l4_ilb_subsetting

image

Expected behavior

Cluster would not be recreated

Observed behavior

Terraform requires the cluster to be recreated

Terraform Configuration

module "gke" {
  source                          = "terraform-google-modules/kubernetes-engine/google//modules/beta-autopilot-private-cluster"
  version                         = "30.0.0"
  project_id                      = var.project_id
  name                            = "cluster-${var.environment}-test"
  region                          = var.region
  release_channel                 = "RAPID"
  network_project_id              = var.network_project
  network                         = var.network
  subnetwork                      = var.subnetwork
  ip_range_pods                   = var.ip_range_pods
  ip_range_services               = var.ip_range_svcs
  horizontal_pod_autoscaling      = true
  enable_vertical_pod_autoscaling = true
  enable_private_endpoint         = false
  enable_private_nodes            = true
  master_ipv4_cidr_block          = var.master_ipv4_cidr_block
  master_authorized_networks      = local.master_authorized_networks
  deletion_protection             = false
  gateway_api_channel             = "CHANNEL_STANDARD"
  network_tags = [
    "allow-gcp-load-balancer-health-check",
  ]
}

Terraform Version

1.6.6

Additional information

This issue might not be just limited to the module, but the core google_container_cluster itself

@kliu47 kliu47 added the bug Something isn't working label Feb 1, 2024
@Rycieos
Copy link

Rycieos commented Feb 9, 2024

It is a module problem. This happens with the root module as well as the beta-autopilot-private-cluster and beta-autopilot-public-cluster modules, but not the beta-public-cluster module, as that can set enable_l4_ilb_subsetting with a variable.

Copy link

github-actions bot commented Apr 9, 2024

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
3 participants