Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No Option for specifying image_type in auto_provisioning_defaults #1904

Closed
endrec opened this issue Mar 18, 2024 · 2 comments · Fixed by #1905
Closed

No Option for specifying image_type in auto_provisioning_defaults #1904

endrec opened this issue Mar 18, 2024 · 2 comments · Fixed by #1905
Labels
enhancement New feature or request Stale

Comments

@endrec
Copy link
Contributor

endrec commented Mar 18, 2024

TL;DR

This issue resurrects #1191, which was closed for some reason without the corresponding PR merged.

The 'auto_provisioning_defaults' block supports image_type

But the option is not available currently in the module still.

Terraform Resources

https://registry.terraform.io/providers/hashicorp/google/latest/docs/resources/container_cluster#image_type

Detailed design

Here is how it could look like:


  cluster_autoscaling {
    enabled = var.cluster_autoscaling.enabled
    dynamic "auto_provisioning_defaults" {
      for_each = var.cluster_autoscaling.enabled ? [1] : []

      content {
        service_account  = local.service_account
        oauth_scopes     = local.node_pools_oauth_scopes["all"]
        min_cpu_platform = lookup(var.node_pools[0], "min_cpu_platform", "")
        image_type       = lookup(var.cluster_autoscaling, "image_type", "")
      }
    }
  }


### Additional information

_No response_
Copy link

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the Stale label May 17, 2024
@endrec
Copy link
Contributor Author

endrec commented May 20, 2024

Still in progress. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Stale
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant