Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing update-variant keepers, breaking gpu_driver_version update #1941

Closed
S4ckBr opened this issue May 14, 2024 · 2 comments
Closed

Missing update-variant keepers, breaking gpu_driver_version update #1941

S4ckBr opened this issue May 14, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@S4ckBr
Copy link

S4ckBr commented May 14, 2024

TL;DR

There is no node-pool recreation after editing the gpu_driver_version field

Expected behavior

  • The terraform apply succeeds
  • The node-pool suffix name should change (update-variant)

Observed behavior

  • The terraform apply fails:
module.gke_cluster.google_container_node_pool.pools["my-node-pool"]: Creating...
╷
│ Error: resource - projects/myproject/locations/us-central1/clusters/my-cluster/nodePools/my-node-pool-XXXX - already exists
│ 
│   with module.gke_cluster.google_container_node_pool.pools["my-node-pool"],
│   on .terraform/modules/gke_cluster/modules/beta-public-cluster-update-variant/cluster.tf line 565, in resource "google_container_node_pool" "pools":
│  565: resource "google_container_node_pool" "pools" {
│ 
╵
  • The node-pool name suffix is not updated. GKE does not support updating in place the gpu_driver_version field. This explains the failure

Terraform Configuration

module "gke_cluster" {
  source  = "terraform-google-modules/kubernetes-engine/google//modules/beta-public-cluster-update-variant"
  version = "30.2.0"

  # Cluster basics
  project_id      = google_project.this.project_id
  name            = "my-cluster"
  region          = "us-central-1"

  ## Node Pools
  remove_default_node_pool = true
  initial_node_count       = 1

  node_pools = [{
    name = "my-node-pool"

    accelerator_count  = 1
    accelerator_type   = "nvidia-tesla-t4"
    gpu_driver_version = "DEFAULT"
  }]
}

Terraform Version

Terraform v1.5.7
on linux_amd64

Additional information

Seems to be fixed by #1913

@DrFaust92
Copy link
Contributor

this can be closed.

cc: @apeabody

@apeabody
Copy link
Contributor

Closed by #1874

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants