fix: Fix the value of output "identity_service_enabled" in beta modules #1982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It should return the value of "Identity Service" feature flag, not "Pod Security Policy"
make build
|
/gcbrun |
List items should be accessed using square brackets (terraform_deprecated_index)
legal90
force-pushed
the
fix-identity-service-output
branch
from
51f4545
to
a0c99d9
Compare
|
/gcbrun |
CPL-markus
pushed a commit
to WALTER-GROUP/terraform-google-kubernetes-engine
that referenced
this pull request
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It should return the value of "Identity Service" feature flag (
local.cluster_identity_service_enabled), not "Pod Security Policy"(local.cluster_pod_security_policy_enabled)It seems that there was a typo in the initial implementation of this feature in #1142.
Note: the local variable
local.cluster_output_identity_service_enabledwas already defined earlier, but it was deleted in #1598 because it wasn't used.