Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests are failing on master #233

Closed
morgante opened this issue Aug 14, 2019 · 6 comments
Closed

Tests are failing on master #233

morgante opened this issue Aug 14, 2019 · 6 comments
Assignees
Labels
bug Something isn't working

Comments

@morgante
Copy link
Contributor

The integration tests are failing on master.

@aaron-lane aaron-lane added the bug Something isn't working label Aug 16, 2019
@morgante morgante mentioned this issue Aug 16, 2019
3 tasks
@ingwarr
Copy link
Contributor

ingwarr commented Aug 21, 2019

As a result of the research, I came to the conclusion that the tests fail because the wrong version of the provider is specified in examples, so we should remove versions from examples and add requirements to autogen/versions.tf. After running make generate all tests passed except stub-domains-private-local, but it removed from CI, I have ideas about how to make it work, I think it is an additional issue)
It looks like:

terraform {
  required_version = ">= 0.12"
  required_providers {
    google-beta = "~> 2.12.0"
    google      = "~> 2.9.0"
  }
}

I saw all the necessary changes made by @paulpalamarchuk in #238

Also for the new beta-cluster-local test, we need to add the appropriate role to GKE default service account Cloud KMS CryptoKey Encrypter/Decrypter I think we should add it to README.md

@ingwarr
Copy link
Contributor

ingwarr commented Aug 21, 2019

image
image
image
image
image
image
image
image
image
image
image
image
image
image
image

@nick4fake
Copy link
Contributor

@morgante regarding beta tests please check my comment here

@nick4fake
Copy link
Contributor

@morgante could you please also confirm that stub-domains-private-local is also in the scope? It has been removed from CI, so we are not sure.

@morgante
Copy link
Contributor Author

@nick4fake I think you might have linked to the wrong comment?

We can skip stub-domains-private-local if it's causing issues.

@morgante
Copy link
Contributor Author

We should NOT remove versions from examples, but simply update them to the correct version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants