Removing dependency on jq from wait-for-cluster.sh script #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobCannon
requested review from
adrienthebo,
Jberlinsky and
morgante
as code owners
morgante
suggested changes
Jan 15, 2020
|
The lint warning for my changes are fixed. |
kri5
pushed a commit
to kri5/terraform-google-kubernetes-engine
that referenced
this pull request
Jan 27, 2020
…orm-google-modules#402) * Removed need for jq in wait-for-cluster.sh script * Updated all wait-for-cluster.sh scripts * Fixing SC2086 warning Co-authored-by: Morgante Pell <morgante.pell@morgante.net>
CPL-markus
pushed a commit
to WALTER-GROUP/terraform-google-kubernetes-engine
that referenced
this pull request
Jul 15, 2024
…orm-google-modules#402) * Removed need for jq in wait-for-cluster.sh script * Updated all wait-for-cluster.sh scripts * Fixing SC2086 warning Co-authored-by: Morgante Pell <morgante.pell@morgante.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The gcloud --format command can be used instead of jq to extract the cluster status for this script.
I will submit a change for the delete-default-resource.sh script in another PR.