Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Output master_ipv4_cidr_block #409

Closed
ghost opened this issue Jan 28, 2020 · 2 comments · Fixed by #427
Closed

Output master_ipv4_cidr_block #409

ghost opened this issue Jan 28, 2020 · 2 comments · Fixed by #427

Comments

@ghost
Copy link

ghost commented Jan 28, 2020

On GKE it's possible to run into issues with using webhooks on private clusters. Examples include prometheus or cert-manager.

The solution is to configure a firewall rule permitting (IIUC) access from hosted masters to GKE nodes, but the master CIDR block is not being output, so it's somewhat messy currently to glue a firewall module and terraform-google-kubernetes-engine module together.

Outputting the master_ipv4_cidr_block would aid in configuring a firewall rule more cleanly.
@morgante
Copy link
Contributor

This makes sense, I'd be happy to accept a PR adding this.

@kravvcu
Copy link
Contributor

kravvcu commented Feb 9, 2020

Added #427

@kravvcu kravvcu mentioned this issue Feb 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Output master_ipv4_cidr_block
2 participants
@morgante @kravvcu