Workload identity submodule #417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
various typo & linting fixes update README with output instead of hardcoded name update README to avoid cycle fix linting add missing outputs to fix linting update readme, generate docs fix linting for workload identity output updates from peer review add integration step for verifying workload identity initial workload identity integration test remove duplicate comment update dev tools version and just focus on workload identity tests here need these dependent steps project_ids is what we're using for variables add project_id output give registry_project_id a default in workload identity since we're not using it generate docs add the kubernetes provider rename cluster service account to work with this module bump google tf provider version newer gke clusters need to use kubernetes monitoring updated variable defaults in readme update monitoring variable in all modules update logging service variable too shorten some names to match identity account_id regex
bharathkkb
requested review from
adrienthebo,
Jberlinsky and
morgante
as code owners
|
@bharathkkb Please address test errors. |
|
@morgante I think the tests are flaky; sandbox-enabled-local for some reason is taking more than 30 mins to bring up the node pools. |
|
@morgante test are passing PTAL |
morgante
suggested changes
Feb 6, 2020
morgante
approved these changes
Feb 7, 2020
This was referenced Feb 7, 2020
CPL-markus
pushed a commit
to WALTER-GROUP/terraform-google-kubernetes-engine
that referenced
this pull request
Jul 15, 2024
…ty) (terraform-google-modules#417) * initial workload identity addition various typo & linting fixes update README with output instead of hardcoded name update README to avoid cycle fix linting add missing outputs to fix linting update readme, generate docs fix linting for workload identity output updates from peer review add integration step for verifying workload identity initial workload identity integration test remove duplicate comment update dev tools version and just focus on workload identity tests here need these dependent steps project_ids is what we're using for variables add project_id output give registry_project_id a default in workload identity since we're not using it generate docs add the kubernetes provider rename cluster service account to work with this module bump google tf provider version newer gke clusters need to use kubernetes monitoring updated variable defaults in readme update monitoring variable in all modules update logging service variable too shorten some names to match identity account_id regex * accept incoming for conflicts on readme * fix WI config, fix tests * re enable all tests * fix vars,op * re enable cloud build for all tests * fix flake8 errors * increase timeout * add defaults, address comments Co-authored-by: Miles Matthias <miles.matthias@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added commits from #307 for Workload Identity