Fix "Invalid index" creating private cluster #422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As google_container_cluster.primary.private_cluster_config may be empty, we check its length before trying to access it. When creating a new private cluster, a "Invalid index" error was showing up during the planning. By checking for variable length before trying to access it the plan (and apply) works as expected. Issue: [terraform-google-modules#419] Co-authored-by: Morgante Pell <morgantep@google.com>
endorama
requested review from
adrienthebo,
Jberlinsky and
morgante
as code owners
endorama
changed the title
Invalid index creating private cluster
CPL-markus
pushed a commit
to WALTER-GROUP/terraform-google-kubernetes-engine
that referenced
this pull request
Jul 15, 2024
…m-google-modules#422) * fix Invalid index error when creating a private cluster As google_container_cluster.primary.private_cluster_config may be empty, we check its length before trying to access it. When creating a new private cluster, a "Invalid index" error was showing up during the planning. By checking for variable length before trying to access it the plan (and apply) works as expected. Issue: [terraform-google-modules#419] Co-authored-by: Morgante Pell <morgantep@google.com> * perform generation Co-authored-by: Morgante Pell <morgante.pell@morgante.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide a fix for #419
Invalid indexerror when creating a private cluster.Closes #419