-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add NodeLocal DNSCache beta addon support #428
Comments
Please make sure you open a provider issue as well. |
Existing Issue: hashicorp/terraform-provider-google#5150 |
This is no longer blocked, 3.14 was released yesterday that includes a |
This change always forces replacement of the cluster, even when is set to false and is also disabled on the cluster. This should not happen... Is the same configured value. |
This seems like a bug in the provider, but we could probably make it a dynamic block. |
@morgante this is it, is solved already hashicorp/terraform-provider-google#6031 |
The solution use |
Just to confirm, it sounds like this is fixed if you upgrade to the latest provider version? In that case I'm going to close this issue. |
I am still seeing this behavior on an existing cluster with nodelocal cache disabled.
|
according to the repo, the fix didnt make it in the v3.17.0 release edit: commits to master after that made it into the release so I don't know what was missed there. |
Ohh man, sorry about that. What I did was enabled it through the gcloud web, changed the config to true, removed the cluster from the state and import it again. edit: I tried this same before doing the upgrade to the beta provider and it didn't worked out. But did after the upgrade, so I assume the change was merged as you mentioned before because other chages to master made it. |
If someone does want to switch this in the module by updating to a dynamic block, I'm happy to review/merge. |
I asked on the original PR and they said it’ll be fixed in the 3.18 release |
looks like it made it.. will test tomorrow |
@jmymy has this been resolved? |
is fixed. just tested and confirmed working. |
Is it available for AKS as well? If not, any work arounds? |
NodeLocal DNSCache was recently promoted to beta, add a flag to enable it for beta modules.
Blocked until beta provider supports it, looking at the GKE REST API this should just be a simple boolean flag
The text was updated successfully, but these errors were encountered: