Add NodeLocal DNSCache beta addon support

[Dev25]

NodeLocal DNSCache was recently promoted to beta, add a flag to enable it for beta modules.

Blocked until beta provider supports it, looking at the GKE REST API this should just be a simple boolean flag

[morgante]

Please make sure you open a provider issue as well.

[Dev25]

Existing Issue: hashicorp/terraform-provider-google#5150

[Dev25]

This is no longer blocked, 3.14 was released yesterday that includes a dns_cache_config field.

[sebastianortizs4n]

This change always forces replacement of the cluster, even when is set to false and is also disabled on the cluster. This should not happen... Is the same configured value.

[morgante]

This seems like a bug in the provider, but we could probably make it a dynamic block.

[sebastianortizs4n]

@morgante this is it, is solved already hashicorp/terraform-provider-google#6031

[sebastianortizs4n]

The solution use google-beta provider 3.17.0

[morgante]

Just to confirm, it sounds like this is fixed if you upgrade to the latest provider version?

In that case I'm going to close this issue.

[jmymy]

I am still seeing this behavior on an existing cluster with nodelocal cache disabled.

Terraform v0.12.24
+ provider.google v3.17.0
+ provider.google-beta v3.17.0

+ dns_cache_config { # forces replacement
             + enabled = false
           }

[jmymy]

according to the repo, the fix didnt make it in the v3.17.0 release
https://github.com/terraform-providers/terraform-provider-google-beta/blob/v3.17.0/google-beta/resource_container_cluster.go#L279

edit: commits to master after that made it into the release so I don't know what was missed there.

[sebastianortizs4n]

Ohh man, sorry about that. What I did was enabled it through the gcloud web, changed the config to true, removed the cluster from the state and import it again.

edit: I tried this same before doing the upgrade to the beta provider and it didn't worked out. But did after the upgrade, so I assume the change was merged as you mentioned before because other chages to master made it.

[morgante]

If someone does want to switch this in the module by updating to a dynamic block, I'm happy to review/merge.

[jmymy]

I asked on the original PR and they said it’ll be fixed in the 3.18 release

[jmymy]

looks like it made it.. will test tomorrow
https://github.com/terraform-providers/terraform-provider-google-beta/releases/tag/v3.18.0

[bharathkkb]

@jmymy has this been resolved?
We may need to look applying this workaround to make it dynamic if it is still persisting.
#497 (comment)

[jmymy]

is fixed. just tested and confirmed working.

[mdaslamansari]

Is it available for AKS as well? If not, any work arounds?