Make workload identity k8s SA configurable #430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jberlinsky
suggested changes
Feb 10, 2020
morgante
force-pushed
the
feat/workload_identity_config
branch
from
6622005
to
f3d0f16
Compare
morgante
changed the title
morgante
force-pushed
the
feat/workload_identity_config
branch
from
f3d0f16
to
1256e6b
Compare
|
Error looks spurious, related to #432. |
bharathkkb
approved these changes
Feb 10, 2020
| source = "terraform-google-modules/gcloud/google" | ||
| version = "~> 0.5" | ||
|
|
||
| platform = "linux" |
There was a problem hiding this comment.
does this need to be parameterized to support darwin gcloud?
There was a problem hiding this comment.
Since I'm disabling download, it doesn't.
CPL-markus
pushed a commit
to WALTER-GROUP/terraform-google-kubernetes-engine
that referenced
this pull request
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases, we want to attach workload identity to an existing Kubernetes Service Account. This updates the module to handle that case.