Use gcloud module in ACM #442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bharathkkb
requested review from
adrienthebo,
Jberlinsky and
morgante
as code owners
morgante
reviewed
Feb 21, 2020
|
@morgante sounds good |
bharathkkb
changed the title
morgante
approved these changes
Mar 19, 2020
CPL-markus
pushed a commit
to WALTER-GROUP/terraform-google-kubernetes-engine
that referenced
this pull request
Jul 15, 2024
…terraform-google-modules#442) * fix acm provisioner errors * use gcloud module * fix tests for terraform-google-modules#454
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor ACM module utilizing the gcloud module
Fixes #454 for beta-cluster failing test by changing checking that json
['nodeConfig']['workloadMetadataConfig']includes"nodeMetadata" => 'EXPOSE'instead of eq.