Remove unused variable service_account in safer-cluster to avoid confusion
#448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
han0110
requested review from
adrienthebo,
Jberlinsky and
morgante
as code owners
morgante
approved these changes
Mar 4, 2020
CPL-markus
pushed a commit
to WALTER-GROUP/terraform-google-kubernetes-engine
that referenced
this pull request
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR: Remove unused variable
service_accountin modulesafer-clusterto avoid confusionI found the document of
safer-clustera little bit confusing because there are two similar variables about worker nodes' service account:compute_engine_service_accountservice_accountAfter digging into the source code, I found the var
service_accountis unused but is the same word used inmainmodule.I think the former one is better understood so I remove the unused one to avoid confusion, even it's the same as the one used in
main.