Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Safer Cluster Update Variant does not propogate zones #449

Closed
jamesthimont opened this issue Mar 7, 2020 · 1 comment
Closed

Safer Cluster Update Variant does not propogate zones #449

jamesthimont opened this issue Mar 7, 2020 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers P3 medium priority issues triaged Scoped and ready for work

Comments

@jamesthimont
Copy link

The gke module is missing the zones property

module "gke" {
  source             = "../beta-private-cluster-update-variant/"
  project_id         = var.project_id
  name               = var.name
  regional           = var.regional
  region             = var.region
 ***zones              = var.zones***
  network            = var.network
  network_project_id = var.network_project_id
@morgante
Copy link
Contributor

morgante commented Mar 7, 2020

Indeed it is! We could should certainly add it.

@morgante morgante added enhancement New feature or request good first issue Good for newcomers P3 medium priority issues triaged Scoped and ready for work labels Mar 7, 2020
This was referenced Apr 2, 2020
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers P3 medium priority issues triaged Scoped and ready for work
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[BUG] pass zones to the parent module for Safer modules
2 participants
@jamesthimont @morgante