Feature: Add autoscaling profiles #456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bharathkkb
requested review from
adrienthebo,
Jberlinsky and
morgante
as code owners
morgante
reviewed
Mar 17, 2020
autogen/main/cluster.tf.tmpl
Outdated
| @@ -68,7 +68,8 @@ resource "google_container_cluster" "primary" { | |||
|
|
|||
| {% if beta_cluster %} | |||
| cluster_autoscaling { | |||
| enabled = var.cluster_autoscaling.enabled | |||
| enabled = var.cluster_autoscaling.enabled | |||
| autoscaling_profile = var.cluster_autoscaling.autoscaling_profile | |||
There was a problem hiding this comment.
Should we set a default here (BALANCED)?
There was a problem hiding this comment.
I have the default in the cluster_autoscaling to BALANCED.
There was a problem hiding this comment.
Right, but that default will only be applied if cluster_autoscaling is omitted entirely. I should be able to specify autoscaling_profile = null to get a sane default (or should the default be disabled?).
There was a problem hiding this comment.
ah, yes good point; will update :)
morgante
approved these changes
Mar 27, 2020
CPL-markus
pushed a commit
to WALTER-GROUP/terraform-google-kubernetes-engine
that referenced
this pull request
Jul 15, 2024
…_autoscaling (terraform-google-modules#456) * add autoscaling_profile * default to balanced if autoscaling_profile is null * default to balanced if autoscaling_profile is null
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #455