Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an auth submodule outputting a kubeconfig #469

Merged
merged 6 commits into from
Apr 14, 2020

Conversation

rileykarson
Copy link
Contributor

@rileykarson rileykarson commented Mar 30, 2020

As well as convenience values for the kubernetes and helm providers.

I'm running the tests following the guide at https://github.com/terraform-google-modules/terraform-google-kubernetes-engine/blob/master/CONTRIBUTING.md#noninteractive-execution, make docker_test_integration has been running since morning though.

/cc @morgante

Fixes #393

@morgante
Copy link
Contributor

morgante commented Mar 30, 2020

@rileykarson Since you're only editing/writing one test, you might want to try using interactive mode to only run that suite. Creating many different GKE clusters is unfortunately indeed very time-consuming.

@bharathkkb
Copy link
Member

bharathkkb commented Mar 31, 2020

@rileykarson +1 this is a great addition

I believe you have not added the fixture that invokes the newly added example and hence the int tests are not being called.

For adding a new test you will also need to make an entry here which will let kitchen know the existence of the test. After that you should be able to do kitchen_do list and find the simple_regional_with_kubeconfig test suite.

Then add an entry here which will let cloud build build that particular suite in parallel.

Regarding the test itself maybe invoking kubeclient using the newly generated kubeconfig maybe a good test. We do something similar here but I will defer to @morgante if there is a need to test at all.

@rileykarson
Copy link
Contributor Author

I added the additional boilerplate, and it appeared to succeed when running in interactive mode. Let me know if you'd like me to exercise the generated kubeconfig.

@bharathkkb
Copy link
Member

LGTM

@morgante morgante merged commit a5ace36 into terraform-google-modules:master Apr 14, 2020
CPL-markus pushed a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this pull request Jul 15, 2024
…ogle-modules#469)

* Add GKE auth submodule

* Add example of auth submodule

* Fix copyright dates

* Linting

* Register test

* Add test fixtures
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generate kubeconfig from output
3 participants