Feature/config sync module #493
Conversation
…, renamed a few vars.
…also made operator credential a lot more configurable
…, renamed a few vars.
…also made operator credential a lot more configurable
…erraform-google-kubernetes-engine into feature/config-sync-module had rebased from upstream
|
|
||
|
|
||
| module "k8s_operator" { | ||
| source = "terraform-google-modules/gcloud/google" |
There was a problem hiding this comment.
nit: I know we havent enabled skip_download before, but imho we should be allowing users to control skip_download for the gcloud module, just like in project factory. @morgante thoughts?
There was a problem hiding this comment.
oh, this is great -- happy to add this here or in a fast following PR. wish i knew this was available, working on this was very slow because of the download and local install everytime!
There was a problem hiding this comment.
yup, I gave config sync a spin locally and manually set it to true for faster apply
There was a problem hiding this comment.
cool, added in 418f9ae
|
Left a few small comments but LGTM 👍 |
…ync templates to test this, so we dont need to support a copy here.
|
@linde Please also regenerate docs, otherwise this should be good to go. |
|
@morgante -- looks like the build ran into a problem. it completed ok in cloudbuild but it isnt reflected here. can you re-kick it off maybe? |
BREAKING CHANGE: The ACM module has been refactored and resources will be recreated. This will show up in Terraform plans but is a safe no-op for Kubernetes.
this is an effort to make a config sync counterpart to the acm module.