Fixes #489 Identity namespace output for beta clusters #500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The identity namespace flag was "enabled". Changed the output value to reference the actual identity namespace of the cluster / the project.
|
I ran all integration tests locally. All tests are running through apart from the following with the following errors:
So maybe you could also give me hint why the pipeline is falling? I did run all steps described in |
|
The acm error looks unrelated, so we can ignore it. |
morgante
approved these changes
May 4, 2020
CPL-markus
pushed a commit
to WALTER-GROUP/terraform-google-kubernetes-engine
that referenced
this pull request
Jul 15, 2024
…oogle-modules#500) * Fixes terraform-google-modules#489 Identity namespace output for beta clusters The identity namespace flag was "enabled". Changed the output value to reference the actual identity namespace of the cluster / the project. * Fixed tests by re-building the module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The identity namespace flag was "enabled". Changed the output value to reference the actual identity namespace of the cluster / the project.
This PR fixes #489.