Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose gce_pd_csi_driver for Safer Cluster modules #503 #514

Merged
merged 2 commits into from
May 11, 2020
Merged

Expose gce_pd_csi_driver for Safer Cluster modules #503 #514

merged 2 commits into from
May 11, 2020

Conversation

rebelthor
Copy link
Contributor

Fixes #503

@rebelthor rebelthor requested review from bharathkkb, Jberlinsky and a team as code owners May 11, 2020 12:09
@bharathkkb
Copy link
Member

Thanks for the PR!
The safer-cluster modules are autogenerated from autogen/safer-cluster. Once you make those changes you can run make build to propagate them to the actual modules.

@rebelthor
Copy link
Contributor Author

@bharathkkb Thanks for the suggestion, I knew I was missing something but I couldn't see the pipelines to understand the error. I've updated the MR and this should be fine now. Can you please recheck? Thanks!

bharathkkb
bharathkkb approved these changes May 11, 2020
View reviewed changes
Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morgante morgante merged commit d4e7dc6 into terraform-google-modules:master May 11, 2020
CPL-markus pushed a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this pull request Jul 15, 2024
@rebelthor
feat: Expose gce_pd_csi_driver for Safer Cluster modules terraform-go…
7f205a2 
…ogle-modules#503 (terraform-google-modules#514)

* Expose gce_pd_csi_driver for Safer Cluster modules terraform-google-modules#503

* Use autogen folder to generate modules terraform-google-modules#503

Co-authored-by: Daniel Patriche <daniel@mambu.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bharathkkb bharathkkb bharathkkb approved these changes

@Jberlinsky Jberlinsky Awaiting requested review from Jberlinsky

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expose gce_pd_csi_driver for Safer Cluster modules
3 participants
@rebelthor @bharathkkb @morgante