Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set auto_provisioning_defaults.service_account ? (beta-public) #560

Closed
lemaral opened this issue Jun 12, 2020 · 4 comments
Closed

Set auto_provisioning_defaults.service_account ? (beta-public) #560

lemaral opened this issue Jun 12, 2020 · 4 comments
Labels
enhancement New feature or request P3 medium priority issues triaged Scoped and ready for work

Comments

@lemaral
Copy link

lemaral commented Jun 12, 2020

When enabling node autoprovisioning, the service account for it stays at "default" and nodes in "automatic" node pools have no rights on Google APIs (e.g. pull from private GCR)
I would have expected that the service account would be set to the same one that is created for the "regular" node pools so that pods scheduled or rescheduled on the automatic node pools would work the same (at least by default).
I believe it is in auto_provisioning_defaults.service_account

@morgante
Copy link
Contributor

Yes we should fill in this property: https://www.terraform.io/docs/providers/google/r/container_cluster.html#service_account

Happy to review a PR.

@morgante morgante added enhancement New feature or request P3 medium priority issues triaged Scoped and ready for work labels Jun 12, 2020
@dpetersen
Copy link
Contributor

In my testing, it seems like NAP wouldn't create any new Node Pools until I went into the web UI for my Terraformed cluster and selected a Service Account in the Node Auto-Provisioning section. I couldn't actually find any errors in the logs, it just wouldn't do anything no matter what I tried. Just mentioning this for anyone else who is similarly stumped.

I would love this to work, so I will attempt a PR if I can figure it out.

@morgante
Copy link
Contributor

FYI I think the fix is what I mentioned above.

@morgante
Copy link
Contributor

Fixed by #639.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request P3 medium priority issues triaged Scoped and ready for work
Projects
None yet
Development

No branches or pull requests

3 participants