Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Services in Binary Authorization modules #575

Closed
imrannayer opened this issue Jun 23, 2020 · 1 comment · Fixed by #584
Closed

Services in Binary Authorization modules #575

imrannayer opened this issue Jun 23, 2020 · 1 comment · Fixed by #584
Labels
enhancement New feature or request good first issue Good for newcomers P3 medium priority issues triaged Scoped and ready for work

Comments

@imrannayer
Copy link
Contributor

Binary authorization module is enabling needed services in project with following two parameters using default value true:

disable_services_on_destroy
disable_dependent_services

This will cause problem if there are other attestors in same project. Is it possible to change the code in
https://github.com/terraform-google-modules/terraform-google-kubernetes-engine/blob/master/modules/binary-authorization/main.tf

from:

module "project-services" {
  source  = "terraform-google-modules/project-factory/google//modules/project_services"
  version = "~> 8.0"

  project_id = var.project_id

  activate_apis = local.required_enabled_apis
}

To:

module "project-services" {
  source  = "terraform-google-modules/project-factory/google//modules/project_services"
  version = "~> 8.0"

  project_id = var.project_id
  activate_apis = local.required_enabled_apis
  disable_services_on_destroy = false
  disable_dependent_services  = false
} 
@morgante
Copy link
Contributor

Yes I think that's a good idea, happy to accept a PR.

@morgante morgante added enhancement New feature or request good first issue Good for newcomers P3 medium priority issues triaged Scoped and ready for work labels Jun 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers P3 medium priority issues triaged Scoped and ready for work
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants