-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PodSecurityPolicy implementation changing the cluster on every iteration #585
Comments
Since this issue is occurring on the provider itself, can you file a bug there please? |
I'm wondering why pod_security_policy_config was declared as a list instead of bool. Reading the documentation --enable-pod-security-policy looks like a bool flag. I'm going to create the issue on the provider. In the mean time I'm using this workaround. |
@msgongora Can you confirm you tested with |
It's happening w/ provider 3.28 as well. The module implementation hasn't change in regard to podsecurirypolicy but yes, also happening with 9.4 |
Regardless of upstream changes, I think we should fix the module interface by:
|
@morgante I think also the previous implementation can be confusing because this option is mean to enable the admission controller, not to define pod security policies. |
Summary:
pod_security_policy_config with default value is causing to update the cluster every time you run terraform using
beta-private-cluster-update-variant
. I was able to verify that this issue came from the provider itself but since I'm facing it because the way it was implemented in this module, I'm reporting it here.How to reproduce it:
At this point I'm expecting to have a state for pod_security_policy_config with value false, something like this:
But google provider isn't creating this state for some reason:
$ terraform state show module.test_cluster.google_container_cluster.primary |grep -A2 pod_security_policy_config
Because of that, gke module will update the cluster every time:
I was able to replicate this issue w/ module version 9.4.0 and google-beta 3.28.0
The text was updated successfully, but these errors were encountered: