Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add instance_group_urls output #618

Merged
merged 1 commit into from
Dec 9, 2020

Conversation

pmiles01
Copy link
Contributor

This PR adds a new output called instance_group_urls - List of instance group URLs which have been assigned to the cluster.

See: https://www.terraform.io/docs/providers/google/r/container_cluster.html#instance_group_urls

@pmiles01 pmiles01 requested review from bharathkkb, Jberlinsky and a team as code owners July 30, 2020 16:06
@comment-bot-dev
Copy link

comment-bot-dev commented Jul 30, 2020

Thanks for the PR! 🚀
✅ Lint checks have passed.

Copy link
Contributor

@morgante morgante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pmiles01 Can you please get tests passing?

@pmiles01
Copy link
Contributor Author

pmiles01 commented Dec 9, 2020

Would be great if you could review and merge this please ?

@morgante morgante merged commit 5623d51 into terraform-google-modules:master Dec 9, 2020
CPL-markus pushed a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this pull request Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants