Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GKE Hub enhancements #637

Open
1 task done
bharathkkb opened this issue Aug 20, 2020 · 1 comment
Open
1 task done

GKE Hub enhancements #637

bharathkkb opened this issue Aug 20, 2020 · 1 comment
Assignees
Labels
enhancement New feature or request triaged Scoped and ready for work

Comments

@bharathkkb
Copy link
Member

bharathkkb commented Aug 20, 2020

Currently we support GKE hub membership registration via SA key. Moving forward we should also consider supporting hub memberships via Workload Identity and via kubeconfig for non GCP Kubernetes clusters.

  • using Workload Identity
module "hub" {
  source                = "terraform-google-modules/kubernetes-engine/google//modules/hub"
  project_id            = "my-project-id"
  cluster_name          = "my-cluster-name"
  location              = module.gke.location
  cluster_endpoint      = module.gke.endpoint
+ use_workload_identity = true
}
  • via kubeconfig
    • kubeconfig will be generated dynamically to prevent diff issues
module "hub" {
  source                = "terraform-google-modules/kubernetes-engine/google//modules/hub"
  project_id            = "my-project-id"
  cluster_name          = "my-cluster-name"
  location              = module.gke.location
  cluster_endpoint      = module.gke.endpoint
+ use_kubeconfig = true
}

TODO:

@bharathkkb bharathkkb self-assigned this Aug 20, 2020
@bharathkkb bharathkkb added enhancement New feature or request triaged Scoped and ready for work labels Aug 20, 2020
@abhinavrau
Copy link
Contributor

abhinavrau commented Jan 11, 2021

@bharathkkb Following up on kubeconfig support, it looks like there is no explicit integration test for the hub module. It is being tested with asm in simple_zonal_with_asm.

To test the use_kubeconfig feature, would it make sense to create a new integration test based on the simple_zonal_with_asm test and use kubeconfig to register with hub?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request triaged Scoped and ready for work
Projects
None yet
Development

No branches or pull requests

2 participants