Expose service account variable #658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloud-pharaoh
requested review from
bharathkkb,
Jberlinsky and
a team
as code owners
|
Thanks for the PR! 🚀 |
|
@cloud-pharaoh thanks for the PR! |
|
@bharathkkb I rebased and it's failing in a different spot now. Can you take a look at the failure? |
|
/gcbrun |
|
looks like that was flaky, we are tracking that here: hashicorp/terraform-provider-google#6021 |
bharathkkb
approved these changes
Sep 10, 2020
There was a problem hiding this comment.
Looks like inconsistent values are being returned for cloudrun config and that is failing one test. This has happened before and I have reopened b/159766801. ASM tests have passed so this LGTM
/cc @morgante
morgante
approved these changes
Sep 10, 2020
CPL-markus
pushed a commit
to WALTER-GROUP/terraform-google-kubernetes-engine
that referenced
this pull request
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default service account will not necessarily have the required permissions to run kubectl commands. Expose service_account_key_file variable from kubectl_wrapper module to use with ASM module.