Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove gcloud_skip_download #674

Closed
bharathkkb opened this issue Sep 15, 2020 · 0 comments · Fixed by #712
Closed

Remove gcloud_skip_download #674

bharathkkb opened this issue Sep 15, 2020 · 0 comments · Fixed by #712
Labels
good first issue Good for newcomers P3 medium priority issues refactor Updates for readability, code cleanliness, DRYness, etc. Only needs Terraform exp. triaged Scoped and ready for work

Comments

@bharathkkb
Copy link
Member

Remove gcloud_skip_download in favor of using env var approach
ref : https://github.com/terraform-google-modules/terraform-google-gcloud/blob/master/CHANGELOG.md#200-2020-08-12
@bharathkkb bharathkkb added good first issue Good for newcomers P3 medium priority issues refactor Updates for readability, code cleanliness, DRYness, etc. Only needs Terraform exp. triaged Scoped and ready for work labels Sep 15, 2020
@marko7460 marko7460 mentioned this issue Oct 15, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers P3 medium priority issues refactor Updates for readability, code cleanliness, DRYness, etc. Only needs Terraform exp. triaged Scoped and ready for work
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: removing gcloud_skip_download variable marko7460/terraform-google-kubernetes-engine
1 participant
@bharathkkb